https://xkcd.com/2867

Alt text:

It’s not just time zones and leap seconds. SI seconds on Earth are slower because of relativity, so there are time standards for space stuff (TCB, TGC) that use faster SI seconds than UTC/Unix time. T2 - T1 = [God doesn’t know and the Devil isn’t telling.]

You are viewing a single thread.
View all comments
35 points
*

I just spent two days debugging a reporting endpoint that takes in two MM-YYYY parameters and tries to pull info between the first day of the month for param1 and the last day of the month for param2 and ended up having to set my date boundaries as

LocalDate startDate = new LocalDate(1, param1.getMonth(), param2.getYear()); //pretty straightforward, right?

//bump month by one, account for rollover, set endDate to the first of that month, then subtract one day

int endMonth = param2.month == 12 ? param2.month + 1 : 1;

LocalDate endDate = new LocalDate(1, endMonth, param2.year).minusDays(1);

This is extraordinarily simply for humans to understand intuitively, but to code it requires accounting for a bunch of backward edge/corner case garbage. The answer, of course, is to train humans to think in Unix epoch time.

permalink
report
reply
2 points

Unix epoch time is wrong too, as it doesn’t include leap seconds, meaning your time difference will be off by up to 15 seconds.

permalink
report
parent
reply
8 points

In the example you gave, wouldn’t the year be off by one when param2.month is 12?

permalink
report
parent
reply
9 points

I was transcribing it from memory and that exact problem cost me like two hours when I was writing it the first time. Well spotted, now write me a unit test for that case.

permalink
report
parent
reply
2 points

Y’know, I legitimately said to myself “I bet they were writing that from memory and just forgot the edge case. I wonder if that was a problem when doing it originally?” before I wrote that comment. 😂 Time to get some Spock tests set up!

permalink
report
parent
reply
13 points

Using YearMonth.atEndOfMonth would have been the easier choice there, I think

permalink
report
parent
reply
15 points

holy shit, yeah it would have. tyvm, I’ll be putting in a PR first thing monday!

permalink
report
parent
reply
5 points

Would you mind trying to explain (ELI5 style) what you did before and why you are excited for this new method for those of us who dont understand code?

permalink
report
parent
reply
4 points

Unix epoch time in UTC, making sure that your local offset and drift are current at the time of conversion to UTC…

permalink
report
parent
reply
2 points

i don’t even care if its wrong, I just want the code to be readable.

permalink
report
parent
reply
2 points

You should care if it’s wrong.

permalink
report
parent
reply
2 points

All dates and times shall be stored and manipulated in Unix time. Only convert to a readable format at the top of the UI, and forget trying to parse user inputs :P that’s just impossible

permalink
report
parent
reply
3 points

I picture this being read by the fred armisen “believe it or not, straight to jail” character

permalink
report
parent
reply

xkcd

!xkcd@lemmy.world

Create post

A community for a webcomic of romance, sarcasm, math, and language.

Community stats

  • 1.7K

    Monthly active users

  • 258

    Posts

  • 5.8K

    Comments

Community moderators