Move fast and break things.
Merge vulnerabilities.
Double the work.
Merge code without tests.
Anything, but don’t let code become stale.
It can work if you have a test zone and only a small amount of people work on a given code base.
Also checks to ensure the code compiles and tests pass before merging, as some quality gateway.
Something like that happened to me yesterday. I reviewed one PR, then some Important Guy came in and said:
- it is nice you reviewed my work, but we need to push this to production right now.
- just fix these things, I described you how. Just copy/paste these snippets
- these are cosmetics, I don’t care
- “cosmetics”, huh? Your shit may just crash
- gfy and push this to production right now
- well, ok
Of course, lack of these “cosmetics” caused crash in production. It’s my fault of course.
The “send it” school of PRs.
Developers: “Move fast and break things.”
Things: break
Developers: surprised Pikachu face