50 points

It’s an internal inside of React.

permalink
report
reply
37 points
1 point

So, we have to blame github user acdlite?

permalink
report
parent
reply
5 points

So using react will get you fired? I knew it!

permalink
report
parent
reply
46 points

What an absolutely shitty peppering string.

permalink
report
reply
58 points

The code file has 32.171 lines, at least after beautifing it. 1MB fucking js code.

permalink
report
parent
reply
36 points

And this is why I hate all web development and the fact that most jobs are web bs these days. Everything has so much crud baked in and including twelve modules with a million functions just to do anything is the norm.

Giving my back my beautiful optimized assembly dangit.

permalink
report
parent
reply
14 points

We have to work under the assumption that most development is done by inexperienced or, to put it bluntly, bad programmers. I would MUCH rather have bad JS code than bad assembly. One may crash a single tab in my browser, the other may crash my entire computer.

permalink
report
parent
reply
7 points

Me: Can I have (small template parser)?

Stackoverflow: No, we have (small template parser) at home.

Small template parser at home: Full-stack web framework

permalink
report
parent
reply
5 points

Don’t worry, this file is likely the output of a bundler.

permalink
report
parent
reply
25 points

What am I looking at here?

permalink
report
reply
56 points

There’s a string stating that the code should not be passed or the employee will be fired. I’d assume this was a test to see if an employee meant to be doing code review was actually doing them. Spoiler, they were not, as OP said they found this in production code.

permalink
report
parent
reply
13 points

I’d go a step further and I suspect it’s a peppering string (i.e. fixed string you add to hashes to defeat rainbow tables). I’d really hope it isn’t as you mentioned because gosh that sounds like a toxic workplace if someone is just leaving landmines around purely to get someone fired.

permalink
report
parent
reply
19 points

More like, you know damn well that Jim keeps passing code reviews without reading a line in them, he’s been talked to, still does it, and you need something actionable to prove it so that you can get someone’s ass in his chair who does their job.

permalink
report
parent
reply
-1 points
*

Would that imply that all quality control is evil?

permalink
report
parent
reply
-1 points

My guess is a “solution” to the age-old problem of needing to store a secret in a file that the user can download, thus making the entire system insecure.

This “solution” appears to be either that the string itself is so outrageous that the user would not believe that it’s the real secret when it is in fact the real secret, leveraging security through obscurity, or else it’s there in place of the real secret that cannot be revealed under pain of death firing, and therefore is accidentally being used instead of that intended secret… so it’s not secret after all.

Unless they’re doing something incredibly clever to substitute that secret string for the real thing when the time is right and doing it in such a way that the user can’t intercept, someone’s getting fired.

permalink
report
parent
reply
5 points

No, it’s not. It’s part of React internals that you shouldn’t use because your app will break. It’s a warning for developers using React. It’s not a secret of any kind.

permalink
report
parent
reply
14 points

I bet the guy who said “looks good to me” still has a job too.

permalink
report
reply
12 points

You should really be using a pre commit hook to catch secrets. Admittedly it may not have caught this, but manual review is (clearly) not always sufficient.

permalink
report
reply

Programmer Humor

!programmerhumor@lemmy.ml

Create post

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

  • Posts must be relevant to programming, programmers, or computer science.
  • No NSFW content.
  • Jokes must be in good taste. No hate speech, bigotry, etc.

Community stats

  • 5.7K

    Monthly active users

  • 1.5K

    Posts

  • 35K

    Comments