115 files changed and almost 3k lines added… sure, I’ll have this reviewed by tomorrow for ya 🙄
My review: “I’'ve always hated this code base, anyway. LGTM.”
I saw a open source project that was basically just an HVAC thermostat that should have been…at most like 5 files and 500 lines of code, take up 28 directories, 1876 lines of code, with full MVC framework, complete with java’s silly bullshit of having like 8 levels of directory…after directory…after directory… to get to the source file.
I fucking hate the state of programming today.
What about the Java practice of having a matching implementation class for every class? Or does that actually serve a purpose, lol.
That pattern makes sense for large distributed systems or mature miceoservice frameworks that undergo constant maintenance or updating. And even then, it’s only useful if the interface is well thought out and designed.
In practice, the interface is whatever you happened to need when you make the service class, and it ends up being a 1:1 service to serviceImpl situation.
Most things don’t need to be a service, a utility class to send emails is fine, you’re not going to “interface” with that in any unique ways that need a service… im rambling on the toilet now
adding a single new vendored package in a go protect
Ask them to submit the boilerplate first?