I’ve started using iCloud fully since they implemented end-to-end encryption, other than that I wouldn’t recommend keeping any (sensitive) data in the cloud if it’s not E2EE
iCloud is good, I use it to back up everything outside of my photos since that would exceed my 5gb limit
I have an iPhone, but I feel like iCloud is slow, and the software is designed to consume storage on low-value files while obscuring ways to reduce usage. This likely drives iCloud subscriptions, so they have not made improved it. With that said, owners of multiple Apple products and users of bundled Apple One probably find the service great or at least convenient.
I like Google Photos (i.e. Google Drive) because it can backup an iPhone easily and comes with 15GB free. If you delete bad photos and photos you won’t miss, it can last a long time. The search and share functions within Google Photos are better, and I find Google cloud services are faster. I minimize what I back up to iCloud so 5 GB works OK.
Apple One bundle and Backblaze for my desktop as a just in case.
I use iCloud with family plan. I also get Apple Music, AppleTV+ and Arcade. I did have Buffalo NAS but found cloud easier and didn’t really trust that NAS. All important stuff (apart photos) I backup to local ssd. I probably should backup photos as well.